Skip to content

Blocksign: Enter emergency mode when invalid blocks have a valid proof - #324

Closed
jtimon wants to merge 3 commits into
ElementsProject:elements-0.14.1from
jtimon:e14-emergency-mode-invalid-blocks
Closed

Blocksign: Enter emergency mode when invalid blocks have a valid proof#324
jtimon wants to merge 3 commits into
ElementsProject:elements-0.14.1from
jtimon:e14-emergency-mode-invalid-blocks

Conversation

@jtimon

@jtimon jtimon commented Mar 27, 2018

Copy link
Copy Markdown
Contributor

If the block.scriptPubKey (aka proof.challenge) is OP_RETURN (the default for regtest-like chains), then the node doesn't enter emergency mode.

Dependencies:

@jtimon
jtimon requested a review from jonasnick March 27, 2018 04:43
@jtimon
jtimon force-pushed the e14-emergency-mode-invalid-blocks branch from 639c891 to faa6cf7 Compare March 27, 2018 05:47
@jtimon
jtimon force-pushed the e14-emergency-mode-invalid-blocks branch from faa6cf7 to 2f9ebe0 Compare August 11, 2018 02:59
@jtimon

jtimon commented Aug 11, 2018

Copy link
Copy Markdown
Contributor Author

Needed rebase.

@jtimon
jtimon force-pushed the e14-emergency-mode-invalid-blocks branch from 2f9ebe0 to 72a87bd Compare August 13, 2018 18:24
@jtimon
jtimon force-pushed the e14-emergency-mode-invalid-blocks branch from 72a87bd to e913a8d Compare September 7, 2018 21:14
@jtimon

jtimon commented Sep 7, 2018

Copy link
Copy Markdown
Contributor Author

Needed rebase

@jtimon jtimon added 0.14.1 and removed 0.14.1 labels Oct 16, 2018
@instagibbs

Copy link
Copy Markdown
Contributor

#323 (comment)

@instagibbs instagibbs closed this Mar 28, 2019
tomt1664 pushed a commit that referenced this pull request Aug 31, 2026
abede47eb8 Merge BlockstreamResearch/simplicity#324: Bitcoin Application for Simplicity
eae2b6f2fd misc: minor changes from #324 review
b2b8577164 cmake: add cmr and bitcoin/cmr to build
df01c33990 Add basic CMake build support for libBitcoinSimplicity
4924ea7c6c Implementation of cmr.c for bitcoin
9782370700 Implementation of exec.c for bitcoin
512feba872 Add SIMPLICITY_FALLTHROUGH macro and enable -Wimplicit-fallthrough in CI

git-subtree-dir: src/simplicity
git-subtree-split: abede47eb835f5d39568cc705cefe5bf9e6ee769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants